Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-117805 / 22.12 / Adding warnings for unused disks with exported pools #7078

Merged
merged 43 commits into from
Sep 23, 2022
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
77a9e70
NAS-117805: Fixed unused disks model
RehanY147 Sep 11, 2022
947d462
NAS-117805: Added warning to new manager
RehanY147 Sep 12, 2022
9cad837
NAS-117805: Update manager.component.ts
RehanY147 Sep 12, 2022
6ca8304
NAS-117805: Update manager.component.ts
RehanY147 Sep 12, 2022
94f79ac
NAS-117805: Update manager.component.ts
RehanY147 Sep 12, 2022
de509a4
NAS-117805: Update manager.component.ts
RehanY147 Sep 12, 2022
5b9895e
Merge branch 'master' into NAS-117805
RehanY147 Sep 12, 2022
48efa43
NAS-117805: Showing warnings for unused disks
RehanY147 Sep 13, 2022
b648b40
NAS-117805: Better warnings included in names
RehanY147 Sep 13, 2022
3bea8bd
Merge branch 'master' into NAS-117805
RehanY147 Sep 13, 2022
e0a231c
NAS-117805: Fixed text
RehanY147 Sep 13, 2022
6c26643
NAS-117805: Update volume-status.ts
RehanY147 Sep 13, 2022
e88acfc
NAS-117805: Update manager.ts
RehanY147 Sep 13, 2022
9465c3e
NAS-117805: Better names for warning text
RehanY147 Sep 13, 2022
aa56a55
NAS-117805: Better variable names
RehanY147 Sep 13, 2022
7643b2b
NAS-117805: Fixed strings
RehanY147 Sep 13, 2022
177a8e7
NAS-117805: Update extend-dialog.component.ts
RehanY147 Sep 13, 2022
7541c48
NAS-117805: Update variable
RehanY147 Sep 13, 2022
eaf325d
NAS-117805: Better variable names
RehanY147 Sep 13, 2022
a1edb0f
NAS-117805: Fixed check
RehanY147 Sep 13, 2022
4911a9e
Merge branch 'master' into NAS-117805
RehanY147 Sep 15, 2022
e32783a
NAS-117805: Using one string
RehanY147 Sep 15, 2022
bb40574
NAS-117805: Removed optional
RehanY147 Sep 15, 2022
15b6a9b
NAS-117805: Review fixes
RehanY147 Sep 15, 2022
1038202
NAS-117805: Update extend-dialog.component.ts
RehanY147 Sep 15, 2022
d503d01
NAS-117805: Moved warning
RehanY147 Sep 15, 2022
d44a49e
NAS-117805: Fix method
RehanY147 Sep 15, 2022
94cc7ac
NAS-117805: Review fixes
RehanY147 Sep 15, 2022
e9ea384
NAS-117805: Review fixes
RehanY147 Sep 15, 2022
5971dca
Merge branch 'master' into NAS-117805
RehanY147 Sep 15, 2022
3d74f4b
NAS-117805: Set type
RehanY147 Sep 15, 2022
9c4a6aa
NAS-117805: Handling select all to show warning
RehanY147 Sep 15, 2022
b84c99c
Merge branch 'master' into NAS-117805
RehanY147 Sep 15, 2022
e378d20
Merge branch 'master' into NAS-117805
RehanY147 Sep 16, 2022
377c6dc
NAS-117805: Fix style
RehanY147 Sep 16, 2022
69097ba
Merge branch 'master' into NAS-117805
RehanY147 Sep 16, 2022
efeaaa4
NAS-117805: Fixed method call
RehanY147 Sep 21, 2022
1d91ec3
NAS-117805: fixed tests
RehanY147 Sep 21, 2022
2c44b0c
NAS-117805: Showing warning for suggested layout
RehanY147 Sep 21, 2022
1adee0f
Merge branch 'master' into NAS-117805
RehanY147 Sep 21, 2022
b49f328
Merge branch 'master' into NAS-117805
RehanY147 Sep 21, 2022
b62369f
NAS-117805: Added disk name to titles
RehanY147 Sep 22, 2022
24cf47c
NAS-117805: Added disk name to title
RehanY147 Sep 22, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
NAS-117805: Added disk name to titles
  • Loading branch information
RehanY147 committed Sep 22, 2022
commit b62369fc7e992a46d85384b1010e954619d15bea
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ export class ManagerComponent implements OnInit, AfterViewInit {
for (const disk of this.disks) {
if (this.shouldWarnAboutExportedPool(disk)) {
this.dialog.warn(
this.translate.instant('Warning'),
this.translate.instant('Warning: ' + disk.name),
this.translate.instant(helptext.exported_pool_warning, { pool: `'${disk.exported_zpool}'` }),
);
}
Expand Down