NAS-117298 / None / NAS-117298: timemaching_quota added in smb-form

[AlexKarpov98]

No description provided.

[undsoft]

According to ticket value for timemachine_quota is number of bytes, so it needs to use [formatter] to show it properly.
Also I am not sure if sending tmemachine_quota = 0 is correct if it is not set.

[AlexKarpov98]

@undsoft - Updated PR

[undsoft]

1. Looks like not sending a value doesn't remove it.
2. I think we should also not send it (clear value) if user unticks Time Machine.

[AlexKarpov98]

@undsoft - fixed

[undsoft]

No changes since my last review.

[codecov]

Codecov Report

Merging #7074 (c817a5a) into master (fba3aba) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7074      +/-   ##
==========================================
+ Coverage   41.15%   41.24%   +0.09%     
==========================================
  Files        1045     1049       +4     
  Lines       46070    46104      +34     
  Branches     6393     6404      +11     
==========================================
+ Hits        18958    19016      +58     
+ Misses      27112    27088      -24     

Impacted Files	Coverage Δ
src/app/helptext/sharing/smb/smb.ts	100.00% <ø> (ø)
...p/pages/sharing/smb/smb-form/smb-form.component.ts	79.84% <ø> (-0.40%)	⬇️
...ix-forms/components/ix-input/ix-input.component.ts	98.80% <100.00%> (+0.05%)	⬆️
...odules/truecommand/truecommand-button.component.ts	64.00% <100.00%> (+3.13%)	⬆️
...form/components/form-array/form-array.component.ts	50.00% <0.00%> (-50.00%)	⬇️
src/app/services/shell.service.ts	6.52% <0.00%> (-5.48%)	⬇️
src/app/services/ws.service.ts	17.03% <0.00%> (ø)
src/app/views/others/others.module.ts	0.00% <0.00%> (ø)
src/app/views/sessions/sessions.module.ts	0.00% <0.00%> (ø)
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[AlexKarpov98]

@undsoft Please check it now :)

[undsoft]

Same issues as during last review:

1. Once I set Time Machine Quota there is no way for me to remove it.
2. If I set Time Machine Quota, but then untick Time Machine checkbox, my expectation is that this removes quota when saved.

[AlexKarpov98]

@undsoft

We need to set 0 manually once the value is empty (updated PR)

[undsoft]

Works correctly now.