Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP feat(sabnzbd) adding exportarr for metrics #17988

Merged
merged 20 commits into from
Feb 14, 2024

Conversation

ac1dburnz
Copy link
Contributor

Description

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@ac1dburnz ac1dburnz requested review from PrivatePuffin and a team as code owners February 6, 2024 06:51
Copy link

gitguardian bot commented Feb 6, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret 6e4d56c charts/stable/sabnzbd/ci/default-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Signed-off-by: Ac1dburn <[email protected]>
@ac1dburnz
Copy link
Contributor Author

I added stuff from my repo by accident. I have corrected them

This docker container doesn’t have probes that work. I always had to use a custom app on my own server. In order to have people use this app the health ports need to be disabled. 

Signed-off-by: Ac1dburn <[email protected]>
@ac1dburnz
Copy link
Contributor Author

@Ornias1993 i made the changes but also had to add one more. The probes dont work on this container, the app builds but i have never had it deploy on my system. I always had to manually disable them on my own catalog. I have disabled them.

@ac1dburnz
Copy link
Contributor Author

IMG_1579

@PrivatePuffin PrivatePuffin marked this pull request as draft February 14, 2024 11:13
@ac1dburnz ac1dburnz marked this pull request as ready for review February 14, 2024 15:43
@PrivatePuffin PrivatePuffin merged commit fc7c559 into truecharts:master Feb 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants