Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prometheus): Add remote write questions #11555

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Aug 14, 2023

Description
Add the ability to enable remote write endpoints for sending Prometheus data to external services. See the [remoteWrite spec] for details on the format.

remoteWrite spec

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@PrivatePuffin
Copy link
Member

Do we allow/account for remote-write on values.yaml?

@SuperQ
Copy link
Contributor Author

SuperQ commented Aug 15, 2023

Yes, remoteWrite is included in both values.yaml and the prometheus template

Add the ability to enable remote write endpoints for sending Prometheus
data to external services. See the [remoteWrite spec] for details on the
format.

[remoteWrite spec](https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#remotewritespec)

Signed-off-by: SuperQ <[email protected]>
@PrivatePuffin
Copy link
Member

awesome! :)

@PrivatePuffin PrivatePuffin merged commit d601539 into truecharts:master Aug 15, 2023
11 of 14 checks passed
@SuperQ
Copy link
Contributor Author

SuperQ commented Aug 15, 2023

Hopefully I got the syntax correct for the questions. :)

@SuperQ SuperQ deleted the remote_write branch August 15, 2023 09:42
@stavros-k
Copy link
Collaborator

Hopefully I got the syntax correct for the questions. :)

If that was the desired output, yea :)

remoteWrite:
  - url:
    basicAuth:
      username:
      password:

@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants