patch to prevent truncation when forwarding a message to a tty #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and causes message truncation. The <PRI> field is skipped within wallmsg() itself.
|
Thanks! Merged manually to master with some minor fixup to the commit message. For future reference see https://commit.style/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch to fprintlog_write() that eliminates a redundant skip past the PRI field of the iov when passing it to wallmsg().
Because wallmsg() assumes the PRI field is the first field present in the iov, it wrongly truncates the hostname and part or all of the message body before writing on the tty.