Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Linux MPI to separate CI job #1497

Merged
merged 1 commit into from
May 29, 2023
Merged

move Linux MPI to separate CI job #1497

merged 1 commit into from
May 29, 2023

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented May 29, 2023

This CI job is failing stochastically - nearly every time in recent days. Thus, I moved it to a completely separate CI job so that the other jobs can continue running and we get coverage reports again.

We should update the required status checks before merging this PR

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this negatively affect coverage? I don't remember where the coverage for the MPI stuff was recorded...

But I like the idea to make coverage reporting work again in general!

@ranocha
Copy link
Member Author

ranocha commented May 29, 2023

We do not test coverage with MPI on Linux at the moment, see

# In addition, it looks like the Linux GitHub runners run out of memory during the 3D tests
# with coverage, so we currently do not test MPI with coverage on Linux. For more details,
# see the discussion at https://github.com/trixi-framework/Trixi.jl/pull/1062#issuecomment-1035901020
cmd = string(Base.julia_cmd())
coverage = occursin("--code-coverage", cmd) && !occursin("--code-coverage=none", cmd)
if !(coverage && Sys.iswindows()) && !(coverage && Sys.islinux())
mpiexec() do cmd
run(`$cmd -n $TRIXI_MPI_NPROCS $(Base.julia_cmd()) --threads=1 --check-bounds=yes $(abspath("test_mpi.jl"))`)

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #1497 (eacb79a) into main (5197fcb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1497   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         360      360           
  Lines       29926    29926           
=======================================
  Hits        28548    28548           
  Misses       1378     1378           
Flag Coverage Δ
unittests 95.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ranocha ranocha merged commit da457e4 into main May 29, 2023
@ranocha ranocha deleted the hr/ci_mpi_new branch May 29, 2023 17:27
ranocha added a commit that referenced this pull request May 30, 2023
ranocha added a commit that referenced this pull request May 30, 2023
* check CI on Julia 1.9

* use the v1.9 stable release

* update dgmulti test (roundoff level changes) (#1449)

* use --heap-size-hint=1G for MPI runs in CI

* adjust tolerance for one DGMulti test

* Revert "move Linux MPI to separate CI job (#1497)"

This reverts commit da457e4.

* update to Julia v1.9

* use package extension on Julia v1.9.0

* Apply suggestions from code review

Co-authored-by: Michael Schlottke-Lakemper <[email protected]>

---------

Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
Co-authored-by: Jesse Chan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants