Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify FirstLineCache implementation #216

Merged
merged 1 commit into from
Oct 13, 2018
Merged

Conversation

robinst
Copy link
Collaborator

@robinst robinst commented Oct 13, 2018

With the SyntaxSet/SyntaxSetBuilder split, there's no point in having
the cached_until anymore, as adding a new syntax means going to a
builder and back anyway. So simplify the code to just always compile all
the regexes.

@keith-hall you can implement #205 after this :)

With the SyntaxSet/SyntaxSetBuilder split, there's no point in having
the cached_until anymore, as adding a new syntax means going to a
builder and back anyway. So simplify the code to just always compile all
the regexes.
@trishume trishume merged commit 8238d80 into master Oct 13, 2018
@trishume trishume deleted the simplify-first-line-cache branch October 13, 2018 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants