Suppress ForbiddenException when listing tables in Iceberg REST #22680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
approved these changes
Jul 16, 2024
|
@ebyhr pls be so kind to add a description about the reasoning to suppress the forbidden exception to help other reviewers. |
nineinchnick
approved these changes
Jul 16, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/rest/TrinoRestCatalog.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sample failure:
{ "type": "io.trino.spi.TrinoException", "message": "Error listing materialized views for catalog lakehouse: Failed to list tables from namespace: default", "cause": { "type": "io.trino.spi.TrinoException", "message": "Failed to list tables from namespace: default", "cause": { "type": "org.apache.iceberg.exceptions.ForbiddenException", "message": "Forbidden: Access Denied", "suppressed": [], "stack": [ "org.apache.iceberg.rest.ErrorHandlers$DefaultErrorHandler.accept(ErrorHandlers.java:212)", "org.apache.iceberg.rest.ErrorHandlers$NamespaceErrorHandler.accept(ErrorHandlers.java:180)", "org.apache.iceberg.rest.ErrorHandlers$NamespaceErrorHandler.accept(ErrorHandlers.java:166)", "org.apache.iceberg.rest.HTTPClient.throwFailure(HTTPClient.java:201)", "org.apache.iceberg.rest.HTTPClient.execute(HTTPClient.java:313)", "org.apache.iceberg.rest.HTTPClient.execute(HTTPClient.java:252)", "org.apache.iceberg.rest.HTTPClient.get(HTTPClient.java:348)", "org.apache.iceberg.rest.RESTClient.get(RESTClient.java:96)", "org.apache.iceberg.rest.RESTClient.get(RESTClient.java:79)", "org.apache.iceberg.rest.RESTSessionCatalog.listTables(RESTSessionCatalog.java:279)", "io.trino.plugin.iceberg.catalog.rest.TrinoRestCatalog.listTables(TrinoRestCatalog.java:228)", "io.trino.plugin.iceberg.IcebergMetadata.listMaterializedViews(IcebergMetadata.java:3048)", "io.trino.plugin.iceberg.IcebergMetadata.getMaterializedViews(IcebergMetadata.java:3058)", "io.trino.plugin.base.classloader.ClassLoaderSafeConnectorMetadata.getMaterializedViews(ClassLoaderSafeConnectorMetadata.java:1178)", "io.trino.tracing.TracingConnectorMetadata.getMaterializedViews(TracingConnectorMetadata.java:1340)", "io.trino.metadata.MetadataManager.getMaterializedViews(MetadataManager.java:1723)", "io.trino.tracing.TracingMetadata.getMaterializedViews(TracingMetadata.java:1412)", "io.trino.metadata.MetadataListing.doGetMaterializedViews(MetadataListing.java:215)", "io.trino.metadata.MetadataListing.getMaterializedViews(MetadataListing.java:206)", "io.trino.connector.system.MaterializedViewSystemTable.addMaterializedViewForCatalog(MaterializedViewSystemTable.java:165)", "io.trino.connector.system.MaterializedViewSystemTable.lambda$cursor$0(MaterializedViewSystemTable.java:140)", "com.google.common.collect.ImmutableList.forEach(ImmutableList.java:423)", "com.google.common.collect.RegularImmutableSortedSet.forEach(RegularImmutableSortedSet.java:90)", "io.trino.connector.system.MaterializedViewSystemTable.cursor(MaterializedViewSystemTable.java:127)", "io.trino.connector.system.SystemPageSourceProvider$1.cursor(SystemPageSourceProvider.java:140)", "io.trino.plugin.base.MappedRecordSet.cursor(MappedRecordSet.java:53)", "io.trino.spi.connector.RecordPageSource.<init>(RecordPageSource.java:37)", "io.trino.connector.system.SystemPageSourceProvider.createPageSource(SystemPageSourceProvider.java:119)", "io.trino.spi.connector.ConnectorPageSourceProvider.createPageSource(ConnectorPageSourceProvider.java:46)", "io.trino.split.PageSourceManager$PageSourceProviderInstance.createPageSource(PageSourceManager.java:84)", "io.trino.split.TableAwarePageSourceProvider.lambda$createPageSource$1(TableAwarePageSourceProvider.java:81)", "java.base/java.util.Optional.orElseGet(Optional.java:364)", "io.trino.split.TableAwarePageSourceProvider.createPageSource(TableAwarePageSourceProvider.java:81)", "io.trino.operator.TableScanOperator.getOutput(TableScanOperator.java:290)", "io.trino.operator.Driver.processInternal(Driver.java:400)", "io.trino.operator.Driver.lambda$process$8(Driver.java:303)", "io.trino.operator.Driver.tryWithLock(Driver.java:706)", "io.trino.operator.Driver.process(Driver.java:295)", "io.trino.operator.Driver.processForDuration(Driver.java:266)", "io.trino.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:890)", "io.trino.execution.executor.timesharing.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:187)", "io.trino.execution.executor.timesharing.TimeSharingTaskExecutor$TaskRunner.run(TimeSharingTaskExecutor.java:565)", "io.trino.$gen.xxx.run(Unknown Source)", "java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)", "java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)", "java.base/java.lang.Thread.run(Thread.java:1570)" ], "errorCode": { "code": 65536, "name": "GENERIC_INTERNAL_ERROR", "type": "INTERNAL_ERROR" } }, "suppressed": [], "stack": [ "io.trino.plugin.iceberg.catalog.rest.TrinoRestCatalog.listTables(TrinoRestCatalog.java:239)", "io.trino.plugin.iceberg.IcebergMetadata.listMaterializedViews(IcebergMetadata.java:3048)", "io.trino.plugin.iceberg.IcebergMetadata.getMaterializedViews(IcebergMetadata.java:3058)", "io.trino.plugin.base.classloader.ClassLoaderSafeConnectorMetadata.getMaterializedViews(ClassLoaderSafeConnectorMetadata.java:1178)", "io.trino.tracing.TracingConnectorMetadata.getMaterializedViews(TracingConnectorMetadata.java:1340)", "io.trino.metadata.MetadataManager.getMaterializedViews(MetadataManager.java:1723)", "io.trino.tracing.TracingMetadata.getMaterializedViews(TracingMetadata.java:1412)", "io.trino.metadata.MetadataListing.doGetMaterializedViews(MetadataListing.java:215)", "io.trino.metadata.MetadataListing.getMaterializedViews(MetadataListing.java:206)", "io.trino.connector.system.MaterializedViewSystemTable.addMaterializedViewForCatalog(MaterializedViewSystemTable.java:165)", "io.trino.connector.system.MaterializedViewSystemTable.lambda$cursor$0(MaterializedViewSystemTable.java:140)", "com.google.common.collect.ImmutableList.forEach(ImmutableList.java:423)", "com.google.common.collect.RegularImmutableSortedSet.forEach(RegularImmutableSortedSet.java:90)", "io.trino.connector.system.MaterializedViewSystemTable.cursor(MaterializedViewSystemTable.java:127)", "io.trino.connector.system.SystemPageSourceProvider$1.cursor(SystemPageSourceProvider.java:140)", "io.trino.plugin.base.MappedRecordSet.cursor(MappedRecordSet.java:53)", "io.trino.spi.connector.RecordPageSource.<init>(RecordPageSource.java:37)", "io.trino.connector.system.SystemPageSourceProvider.createPageSource(SystemPageSourceProvider.java:119)", "io.trino.spi.connector.ConnectorPageSourceProvider.createPageSource(ConnectorPageSourceProvider.java:46)", "io.trino.split.PageSourceManager$PageSourceProviderInstance.createPageSource(PageSourceManager.java:84)", "io.trino.split.TableAwarePageSourceProvider.lambda$createPageSource$1(TableAwarePageSourceProvider.java:81)", "java.base/java.util.Optional.orElseGet(Optional.java:364)", "io.trino.split.TableAwarePageSourceProvider.createPageSource(TableAwarePageSourceProvider.java:81)", "io.trino.operator.TableScanOperator.getOutput(TableScanOperator.java:290)", "io.trino.operator.Driver.processInternal(Driver.java:400)", "io.trino.operator.Driver.lambda$process$8(Driver.java:303)", "io.trino.operator.Driver.tryWithLock(Driver.java:706)", "io.trino.operator.Driver.process(Driver.java:295)", "io.trino.operator.Driver.processForDuration(Driver.java:266)", "io.trino.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:890)", "io.trino.execution.executor.timesharing.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:187)", "io.trino.execution.executor.timesharing.TimeSharingTaskExecutor$TaskRunner.run(TimeSharingTaskExecutor.java:565)", "io.trino.$gen.xxx.run(Unknown Source)", "java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)", "java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)", "java.base/java.lang.Thread.run(Thread.java:1570)" ], "errorCode": { "code": 84148237, "name": "ICEBERG_CATALOG_ERROR", "type": "EXTERNAL" } }, "suppressed": [], "stack": [ "io.trino.metadata.MetadataListing.handleListingException(MetadataListing.java:358)", "io.trino.metadata.MetadataListing.getMaterializedViews(MetadataListing.java:209)", "io.trino.connector.system.MaterializedViewSystemTable.addMaterializedViewForCatalog(MaterializedViewSystemTable.java:165)", "io.trino.connector.system.MaterializedViewSystemTable.lambda$cursor$0(MaterializedViewSystemTable.java:140)", "com.google.common.collect.ImmutableList.forEach(ImmutableList.java:423)", "com.google.common.collect.RegularImmutableSortedSet.forEach(RegularImmutableSortedSet.java:90)", "io.trino.connector.system.MaterializedViewSystemTable.cursor(MaterializedViewSystemTable.java:127)", "io.trino.connector.system.SystemPageSourceProvider$1.cursor(SystemPageSourceProvider.java:140)", "io.trino.plugin.base.MappedRecordSet.cursor(MappedRecordSet.java:53)", "io.trino.spi.connector.RecordPageSource.<init>(RecordPageSource.java:37)", "io.trino.connector.system.SystemPageSourceProvider.createPageSource(SystemPageSourceProvider.java:119)", "io.trino.spi.connector.ConnectorPageSourceProvider.createPageSource(ConnectorPageSourceProvider.java:46)", "io.trino.split.PageSourceManager$PageSourceProviderInstance.createPageSource(PageSourceManager.java:84)", "io.trino.split.TableAwarePageSourceProvider.lambda$createPageSource$1(TableAwarePageSourceProvider.java:81)", "java.base/java.util.Optional.orElseGet(Optional.java:364)", "io.trino.split.TableAwarePageSourceProvider.createPageSource(TableAwarePageSourceProvider.java:81)", "io.trino.operator.TableScanOperator.getOutput(TableScanOperator.java:290)", "io.trino.operator.Driver.processInternal(Driver.java:400)", "io.trino.operator.Driver.lambda$process$8(Driver.java:303)", "io.trino.operator.Driver.tryWithLock(Driver.java:706)", "io.trino.operator.Driver.process(Driver.java:295)", "io.trino.operator.Driver.processForDuration(Driver.java:266)", "io.trino.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:890)", "io.trino.execution.executor.timesharing.PrioritizedSplitRunner.process(PrioritizedSplitRunner.java:187)", "io.trino.execution.executor.timesharing.TimeSharingTaskExecutor$TaskRunner.run(TimeSharingTaskExecutor.java:565)", "io.trino.$gen.xxx.run(Unknown Source)", "java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)", "java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)", "java.base/java.lang.Thread.run(Thread.java:1570)" ], "errorCode": { "code": 84148237, "name": "ICEBERG_CATALOG_ERROR", "type": "EXTERNAL" } }Release notes
(x) This is not user-visible or is docs only, and no release notes are required.