Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure SDK #22485

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Update Azure SDK #22485

merged 1 commit into from
Jun 25, 2024

Conversation

nineinchnick
Copy link
Member

Azure SDK version 1.2.24 includes Azure Storage Blob 12.26, which introduces a breaking change (Azure/azure-sdk-for-java#37711), where blob names used to create a new blob client should not be URL-encoded anymore. Blob URLs in the storage don't change, so after adjusting the API usage, data written by older Trino versions should be readable by new Trino versions.

In #21586 we added tests for special characters.

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@wendigo wendigo mentioned this pull request Jun 24, 2024
@wendigo
Copy link
Contributor

wendigo commented Jun 24, 2024

Caused by: io.trino.spi.TrinoException: Error opening Hive split abfs:https://[email protected]/test-delta-lake-integration-smoke-test-bllj11jwnx/test_uri_table_qxwqmtv6gu/part=a%3Dequal/part-00000-d6a0dd7d-8416-436d-bb00-245452904a81.c000.snappy.parquet (offset=0, length=475): abfs:https://[email protected]/test-delta-lake-integration-smoke-test-bllj11jwnx/test_uri_table_qxwqmtv6gu/part=a%3Dequal/part-00000-d6a0dd7d-8416-436d-bb00-245452904a81.c000.snappy.parquet

Azure SDK version 1.2.24 includes Azure Storage Blob 12.26, which
introduces a breaking change, where blob names used to create a new blob
client should not be URL-encoded anymore. Blob URLs in the storage don't
change, so after adjusting the API usage, data written by older Trino
versions should be readable by new Trino versions.
@github-actions github-actions bot added the delta-lake Delta Lake connector label Jun 25, 2024
Copy link
Member

@anusudarsan anusudarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. did you figure out the issue with the failing test?

@nineinchnick
Copy link
Member Author

@anusudarsan yes, there was some extra encoding during test setup that's no longer necessary, since the Azure SDK now properly handles that in all cases.

@wendigo wendigo merged commit 88e4a5c into trinodb:master Jun 25, 2024
194 of 197 checks passed
@nineinchnick nineinchnick deleted the update-azure-libs branch June 25, 2024 14:44
@github-actions github-actions bot added this to the 451 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector
Development

Successfully merging this pull request may close these issues.

None yet

3 participants