Use the actual partition name from the storage in syncing partition metadata #22484
+155
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajaks
reviewed
Jun 27, 2024
| .map(ImmutableSet::copyOf) | ||
| .orElseThrow(() -> new TableNotFoundException(schemaTableName)); | ||
| String tableLocationDirectory = table.getStorage().getLocation().endsWith("/") ? table.getStorage().getLocation() : table.getStorage().getLocation() + "/"; |
There was a problem hiding this comment.
Can you use tableLocation here?
Also you could move this logic to getPartitionNameFromPartitionLocation as it's only used there.
There was a problem hiding this comment.
Slightly modified the code.
@pajaks besides code cosmetics, do you have any concerns with regards to the bugfix?
findinpath
force-pushed
the
findinpath/sync_partition_metadata_bugfix
branch
from
b99d0b8
to
d55f9bf
Compare
anusudarsan
reviewed
Jul 1, 2024
.../trino-hive/src/main/java/io/trino/plugin/hive/procedure/SyncPartitionMetadataProcedure.java
Outdated
Show resolved
Hide resolved
.../trino-hive/src/main/java/io/trino/plugin/hive/procedure/SyncPartitionMetadataProcedure.java
Show resolved
Hide resolved
electrum
approved these changes
Jul 1, 2024
.../trino-hive/src/main/java/io/trino/plugin/hive/procedure/SyncPartitionMetadataProcedure.java
Outdated
Show resolved
Hide resolved
.../trino-hive/src/main/java/io/trino/plugin/hive/procedure/SyncPartitionMetadataProcedure.java
Outdated
Show resolved
Hide resolved
.../trino-hive/src/main/java/io/trino/plugin/hive/procedure/SyncPartitionMetadataProcedure.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/sync_partition_metadata_bugfix
branch
from
d55f9bf
to
0e5eab6
Compare
ebyhr
reviewed
Jul 2, 2024
.../trino-hive/src/main/java/io/trino/plugin/hive/procedure/SyncPartitionMetadataProcedure.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/sync_partition_metadata_bugfix
branch
2 times, most recently
from
6dcc49c
to
0bf6b32
Compare
…etadata The canonical partition name built from the column name and values of the partition may differ in case from the actual storage location of the partition. This can lead to inconsistencies when syncing partition metadata, like identifying a partition to add/remove when there is actually nothing to be done. In case of dealing with conventional partition locations, rely on the partition name from the storage location for identifying the partitions to sync via the `sync_partition_metadata` procedure call. An example of how to add through Hive a partition with non-conventional location: ``` ALTER TABLE ... ADD PARTITION (...) LOCATION '...' ```
findinpath
force-pushed
the
findinpath/sync_partition_metadata_bugfix
branch
from
0bf6b32
to
96a822d
Compare
anusudarsan
approved these changes
Jul 2, 2024
| @@ -116,6 +119,45 @@ public void testSyncPartitionMetadataWithNullArgument() | |||
| super.testSyncPartitionMetadataWithNullArgument(); | |||
| } | |||
|
|
|||
| @Test(groups = SMOKE) | |||
| public void testAddNonConventionalHivePartition() | |||
ebyhr
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The canonical partition name built from the column name and values of the partition may differ from the actual storage location of the partition. This can lead to inconsistencies when syncing partition metadata, like identifying a partition to add/remove when there is actually nothing to be done.
Rely on the partition name from the storage location for identifying the partitions to sync via the
sync_partition_metadataprocedure call.Additional context and related issues
This fix applies specifically where there is a partition name case sensitive variation between the canonical name and the storage location of the partition.
See
io.trino.plugin.hive.TestHive3OnDataLake#testSyncPartitionCaseSensitivePathVariationfor details.Follow-up from #21168
Release notes
(x) Release notes are required, with the following suggested text: