Add special characters missing test coverage for native-fs s3 path #22476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't we do this as a regular JUnit test? Why does it need to be a product test? Please see https://trino.io/docs/current/develop/tests.html#avoid-product-tests cc @electrum |
|
We should convert the existing tests to use native. We don’t need more product tests. The only usefulness of a product test is to verify that the feature works at all (such as due to some class loader issue). It doesn’t need to test full functionality — that should be done in unit tests. |
anusudarsan
force-pushed
the
anu/extend-s3-tests-for-native-fs
branch
from
93e89a7
to
d8c22f9
Compare
|
updated |
anusudarsan
force-pushed
the
anu/extend-s3-tests-for-native-fs
branch
from
d8c22f9
to
cfb74de
Compare
ebyhr
changed the title
ebyhr
approved these changes
Jun 26, 2024
plugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/TestHiveS3MinioQueries.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/TestHiveS3MinioQueries.java
Outdated
Show resolved
Hide resolved
anusudarsan
force-pushed
the
anu/extend-s3-tests-for-native-fs
branch
from
cfb74de
to
801d186
Compare
ebyhr
force-pushed
the
anu/extend-s3-tests-for-native-fs
branch
from
801d186
to
e51aa9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.