Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use List/Set injection into configuration #22460

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jun 20, 2024

This makes configuration more explicit in regard to expected types. Mostly a cleanup

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jun 20, 2024
@wendigo wendigo requested review from electrum and martint June 20, 2024 17:24
@github-actions github-actions bot added hudi Hudi connector hive Hive connector labels Jun 20, 2024
@wendigo wendigo requested a review from losipiuk June 20, 2024 17:24
This makes configuration more explicit in regard to expected types
@wendigo wendigo force-pushed the serafin/use-direct-injection branch from 09a4996 to 44a8277 Compare June 20, 2024 17:26
@wendigo wendigo requested review from findepi and jkylling June 20, 2024 17:29
@wendigo
Copy link
Contributor Author

wendigo commented Jun 20, 2024

Configuration classes should get expected types, rather than parsing them. This aligns better with the idea of introduction of alternate formats to Java properties (like TOML)

@wendigo wendigo requested a review from ebyhr June 21, 2024 08:18
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems mostly fine - but not 100% backward compatible.

@wendigo
Copy link
Contributor Author

wendigo commented Jun 21, 2024

@losipiuk it is, string.toUpperCase was needed to call Enum.valueOf but this is handled by airlift.

@wendigo
Copy link
Contributor Author

wendigo commented Jun 21, 2024

@losipiuk there are tests in both Trino and Airlift that are setting configuration properties mapped to enum with a lower case strings

@losipiuk
Copy link
Member

ok

@wendigo
Copy link
Contributor Author

wendigo commented Jun 21, 2024

@losipiuk i.e. here:

.put("openlineage-event-listener.disabled-facets", "trino_metadata,trino_query_statistics")

as this maps to:

OpenLineageTrinoFacet
{
    TRINO_METADATA,
    TRINO_QUERY_STATISTICS,
    TRINO_QUERY_CONTEXT;
}

@wendigo wendigo merged commit 5dc1afe into master Jun 21, 2024
104 checks passed
@wendigo wendigo deleted the serafin/use-direct-injection branch June 21, 2024 11:41
@github-actions github-actions bot added this to the 451 milestone Jun 21, 2024
@colebow
Copy link
Member

colebow commented Jun 25, 2024

Does this need a release note? @wendigo

@wendigo
Copy link
Contributor Author

wendigo commented Jun 25, 2024

@colebow no.

@colebow colebow added the no-release-notes This pull request does not require release notes entry label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hive Hive connector hudi Hudi connector no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

None yet

3 participants