-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate identity column to integration tests in Delta #22448
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/delta-generated-column
branch
from
June 20, 2024 05:17
4e21f7a
to
4402a68
Compare
pajaks
reviewed
Jun 26, 2024
...n/trino-delta-lake/src/test/resources/databricks133/identity_columns_table_feature/README.md
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Outdated
Show resolved
Hide resolved
SemionPar
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT % nit
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Show resolved
Hide resolved
...n/trino-delta-lake/src/test/resources/databricks133/identity_columns_table_feature/README.md
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Outdated
Show resolved
Hide resolved
findinpath
approved these changes
Jul 12, 2024
pajaks
approved these changes
Jul 31, 2024
mosabua
added
stale-ignore
Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
and removed
stale
labels
Aug 21, 2024
I assume you will run with this @ebyhr |
ebyhr
force-pushed
the
ebi/delta-generated-column
branch
from
August 30, 2024 01:40
4402a68
to
9c2bb2f
Compare
raunaqmorarka
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
delta-lake
Delta Lake connector
stale-ignore
Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows https://trino.io/docs/current/develop/tests.html#avoid-product-tests
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.