Add support for prefix configuration in Iceberg REST catalog #22441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
reviewed
Jun 19, 2024
|
cc: @snazy, @dimas-b, @danielcweeks |
dimas-b
approved these changes
Jun 19, 2024
wendigo
reviewed
Jun 19, 2024
| @@ -85,6 +87,7 @@ public synchronized TrinoCatalog create(ConnectorIdentity identity) | |||
| ImmutableMap.Builder<String, String> properties = ImmutableMap.builder(); | |||
| properties.put(CatalogProperties.URI, serverUri.toString()); | |||
| warehouse.ifPresent(location -> properties.put(CatalogProperties.WAREHOUSE_LOCATION, location)); | |||
| prefix.ifPresent(prefix -> properties.put("prefix", prefix)); | |||
There was a problem hiding this comment.
Can this be added to CatalogProperties in Iceberg?
There was a problem hiding this comment.
This is specific to single catalog (not all catalogs). Hence, it was not added I guess.
Plus change at Iceberg needs a release, which will take time. We can update in the followup if the community agrees on it.
ebyhr
reviewed
Jun 19, 2024
There was a problem hiding this comment.
REST catalog: Support prefix configuration
Please follow the commit message guideline. You can change to "Add support for prefix configuration in Iceberg REST catalog" or something.
https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages
ebyhr
reviewed
Jun 19, 2024
...eberg/src/main/java/io/trino/plugin/iceberg/catalog/rest/TrinoIcebergRestCatalogFactory.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Jun 20, 2024
ajantha-bhat
changed the title
REST catalog supports a `prefix` in the resource path as per the spec. But it is not exposed from Trino `IcebergRestCatalogConfig`. In Spark, this works by default because they accept generic property bag.
ebyhr
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
REST catalog supports a
prefixin the resource path as per the spec. But it is not exposed from TrinoIcebergRestCatalogConfig. In Spark, this works by default because they accept generic property bag.Additional context and related issues
Iceberg side usage:
https://github.com/apache/iceberg/blob/cbd11d7aa54a3b531f59a5e83411a163f9126a0c/core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java#L31
Release notes