Expose driver execution stats via JMX #22427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
reviewed
Jun 18, 2024
| @@ -272,4 +278,50 @@ public DistributionStat getCpuInputByteRate() | |||
| { | |||
| return cpuInputByteRate; | |||
| } | |||
|
|
|||
| @Managed | |||
There was a problem hiding this comment.
I think you already have these in TimeSharingTaskExecutor, e.g: io.trino.execution.executor.timesharing.TimeSharingTaskExecutor#getRunningSplits,
io.trino.execution.executor.timesharing.TimeSharingTaskExecutor#getWaitingSplits
Probably just no completedDrivers, but I'm not sure it's important
There was a problem hiding this comment.
TimeSharingTaskExecutor is on worker - right? This is coordinator metric
losipiuk
force-pushed
the
lukaszos/expose-driver-execution-stats-via-jmx-e90acb
branch
2 times, most recently
from
01a76e2
to
2589b99
Compare
findepi
approved these changes
Jun 19, 2024
core/trino-main/src/main/java/io/trino/dispatcher/DispatchManager.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lukaszos/expose-driver-execution-stats-via-jmx-e90acb
branch
from
2589b99
to
845901c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: