Check duplicated field names in Iceberg #22409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/iceberg-row-field-names
branch
2 times, most recently
from
a7de18c
to
81e2dec
Compare
findepi
reviewed
Jun 18, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Jun 18, 2024
| @@ -6595,6 +6595,41 @@ public void testDeleteRetainsMetadataFile() | |||
| assertUpdate("DROP TABLE " + tableName); | |||
| } | |||
|
|
|||
| @Test | |||
| @Override // Override because ambiguous field name is disallowed in the connector | |||
findepi
reviewed
Jun 18, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
findepi
approved these changes
Jun 18, 2024
ebyhr
force-pushed
the
ebi/iceberg-row-field-names
branch
from
81e2dec
to
f4f8c9d
Compare
anusudarsan
approved these changes
Jun 18, 2024
ebyhr
force-pushed
the
ebi/iceberg-row-field-names
branch
from
f4f8c9d
to
de69319
Compare
ebyhr
force-pushed
the
ebi/iceberg-row-field-names
branch
from
de69319
to
e9609fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should fix Delta Lake connector as a follow-up.
Fixes #16273
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.