-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spelling errors in documentation #22371
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Emily Sunaryo.
|
@@ -24,7 +24,7 @@ typically resulting from a condition in a `WHERE` clause to omit unnecessary | |||
rows. The processing is pushed down to the data source by the connector and then | |||
processed by the data source. | |||
|
|||
If predicate pushdown for a specific clause is succesful, the `EXPLAIN` plan | |||
If predicate pushdown for a specific clause is successful, the `EXPLAIN` plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the same typo in json.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just do a global search for that typo and fix all of them in this PR
Please fix commit message to follow https://trino.io/development/process#contribution-process .. specifically https://cbea.ms/git-commit/ Once CLA is processed we can merge. |
The current commit title looks good to me. What's your suggestion? |
Typically commit message should not talk about what file is affected .. especially also since you might add other files. You could do something like
|
3c5ab53
to
a783230
Compare
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Emily Sunaryo.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Emily Sunaryo.
|
@cla-bot check |
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Emily Sunaryo.
|
The cla-bot has been summoned, and re-checked this pull request! |
d51ee4f
to
2279aa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thank you.
Description
In this PR, I edited 3 typos in the pushdown.md documents.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: