Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling errors in documentation #22371

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

emilysunaryo
Copy link
Contributor

Description

In this PR, I edited 3 typos in the pushdown.md documents.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Copy link

cla-bot bot commented Jun 13, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Emily Sunaryo.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@github-actions github-actions bot added the docs label Jun 13, 2024
@@ -24,7 +24,7 @@ typically resulting from a condition in a `WHERE` clause to omit unnecessary
rows. The processing is pushed down to the data source by the connector and then
processed by the data source.

If predicate pushdown for a specific clause is succesful, the `EXPLAIN` plan
If predicate pushdown for a specific clause is successful, the `EXPLAIN` plan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the same typo in json.md?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just do a global search for that typo and fix all of them in this PR

@mosabua
Copy link
Member

mosabua commented Jun 13, 2024

Please fix commit message to follow https://trino.io/development/process#contribution-process .. specifically https://cbea.ms/git-commit/

Once CLA is processed we can merge.

@ebyhr
Copy link
Member

ebyhr commented Jun 14, 2024

Please fix commit message

The current commit title looks good to me. What's your suggestion?

@mosabua
Copy link
Member

mosabua commented Jun 17, 2024

Please fix commit message

The current commit title looks good to me. What's your suggestion?

Typically commit message should not talk about what file is affected .. especially also since you might add other files. You could do something like

Fix spelling errors in documentation or Correct spelling in docs or Fix grammar issues in docs or similar.

Copy link

cla-bot bot commented Jun 18, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Emily Sunaryo.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@mosabua mosabua changed the title Fix typos in pushdown.md docs Fix typos in docs Jun 18, 2024
@mosabua mosabua changed the title Fix typos in docs Fix spelling errors in documentation Jun 18, 2024
Copy link

cla-bot bot commented Jun 20, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Emily Sunaryo.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@mosabua
Copy link
Member

mosabua commented Jun 26, 2024

@cla-bot check

Copy link

cla-bot bot commented Jun 26, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Emily Sunaryo.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Jun 26, 2024

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you.

@mosabua mosabua merged commit 801a531 into trinodb:master Jun 27, 2024
3 checks passed
@github-actions github-actions bot added this to the 451 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants