Session properties support for Prometheus Connector. #22368
+173
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitkharb
force-pushed
the
22319
branch
2 times, most recently
from
e335e3f
to
afaea47
Compare
github-actions
bot
added
docs
hudi
amitkharb
removed
hudi
github-actions
bot
added
jdbc
amitkharb
removed
jdbc
amitkharb
removed
hive
|
Hi @ebyhr, could you please review this PR. Thank you |
ebyhr
reviewed
Jul 8, 2024
Updated the description, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the session properties support for Prometheus Connector.
Additional context and related issues
Not all metrics are ingested equally, sizes of different metrics may differ.
When the size of a particular metric is significantly larger than other metrics, prometheus connector was not able to handle it and was throwing exception with the default prometheus_query_chunk_size_duration and prometheus_max_query_range_duration. Reducing the chunk size and query range duration helped.
Also for small size metrics, we want larger chunk size and query range duration. Creating the session properties is the best way to control those values in an automated ETL pipeline.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( x) Release notes are required, with the following suggested text: