Allowing users to provide additional http headers for Prometheus Client. #22300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitkharb
force-pushed
the
21394-2
branch
2 times, most recently
from
9428534
to
c0e7892
Compare
ebyhr
reviewed
Jun 6, 2024
plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-prometheus/src/main/java/io/trino/plugin/prometheus/PrometheusConnectorConfig.java
Outdated
Show resolved
Hide resolved
...trino-prometheus/src/test/java/io/trino/plugin/prometheus/TestPrometheusConnectorConfig.java
Outdated
Show resolved
Hide resolved
|
@ebyhr , hi, could you please have a look at this, all the changes you put in the review are now implemented, Thank you |
ebyhr
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prometheus endpoint may require additional http headers. Adding the configuration properties for the same
Example of additional header "X-Scope-orgID" , "default"
Fixes #21394
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.