Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for SHOW CREATE FUNCTION statement #22123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jessie212
Copy link
Contributor

Description

This PR:

  • Fleshes out the SHOW CREATE FUNCTION doc.
  • Updates relevant docs.
  • Add examples.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 24, 2024
@Jessie212 Jessie212 requested a review from mosabua May 24, 2024 15:44
@github-actions github-actions bot added the docs label May 24, 2024
docs/src/main/sphinx/routines/examples.md Outdated Show resolved Hide resolved
SHOW FUNCTIONS FROM example.default
```

Of the functions returned, find all that match a character pattern. This example
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test if you can combine from and like and make an example with that.

docs/src/main/sphinx/routines/examples.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/routines/introduction.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/show-create-function.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/show-create-function.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/show-create-function.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/show-create-function.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/show-create-function.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/show-create-function.md Outdated Show resolved Hide resolved
@mosabua
Copy link
Member

mosabua commented Jun 27, 2024

Please just fix and improve what you can and push those changes.. then we can review again and take the next steps.

@mosabua
Copy link
Member

mosabua commented Jul 5, 2024

Ping me when you think its ready and I should review again..

```

The following example specifies the default SQL path, then uses `SHOW CREATE
FUNCTION` to display the definition of the `answer` SQL routine found on the
Copy link
Contributor Author

@Jessie212 Jessie212 Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this text becomes coded like this in my editor. It renders fine, though.

@mosabua
Copy link
Member

mosabua commented Jul 22, 2024

What is the status here? Is this ready for a review?

@Jessie212
Copy link
Contributor Author

What is the status here? Is this ready for a review?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants