Make it easier to use AWS classes as a custom credentials provider #22007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
trino.s3.credentials-provider
configuration property allows specifying a class used as the credentials provider, but it requires the class to have a constructor that accepts a URI and a Configuration object. The AWS SDK classes implementingAWSCredentialsProvider
have constructors without any arguments, so to use them, a wrapper class had to be created, and an extra JAR had to be added to the deployment.Trying to instantiate the custom credentials provider class without any arguments makes it easier to pin to exactly one provider without using the default providers chain.
This actually makes the docs correct, because it already mentioned using providers from the AWS SDK, which was not possible without a wrapper class.
This at least makes the workaround for #15267 easier, I'm not sure if it will allow closing that issue.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: