Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FIRST and AFTER clause when adding a new column in engine and Iceberg connector #20914

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Mar 4, 2024

Description

This needs syntax review as the corresponding rule doesn't exist in SQL standard.

Datasources supporting these options:

Fixes #20091

Release notes

(x) Release notes are required, with the following suggested text:

# General, Iceberg
* Add support `FIRST` and `AFTER` clause when adding a new column. ({issue}`20091`)

@cla-bot cla-bot bot added the cla-signed label Mar 4, 2024
@github-actions github-actions bot added docs tests:hive iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector mongodb MongoDB connector labels Mar 4, 2024
@ebyhr ebyhr self-assigned this Mar 4, 2024
@ebyhr ebyhr force-pushed the ebi/add-column-after branch 2 times, most recently from 4cd3d46 to a111e6d Compare March 4, 2024 06:48
@findinpath
Copy link
Contributor

findinpath commented Mar 4, 2024

From a Zoom Meeting with @martint , @electrum

Support adding a field with ADD COLUMN in Iceberg
#16321

It would be nice to support adding nested fields in ROW types.

Positioning of the fields seems also attractive (FIRST/ AFTER column), but it is not in the spec.
Reference https://iceberg.apache.org/docs/latest/spark-ddl/
Alternative scenario in Trino for specifying the exact position of the new nested field in the row: ALTER COLUMN ... SET DATA TYPE

FIRST/AFTER - let’’s wait for request from the community to actually start any work on this area.

@ebyhr ebyhr marked this pull request as ready for review April 16, 2024 01:40
@ebyhr ebyhr added the stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. label May 13, 2024
@ebyhr ebyhr force-pushed the ebi/add-column-after branch 4 times, most recently from 952d1a0 to 3685a36 Compare May 20, 2024 08:01
@ebyhr ebyhr requested a review from martint May 21, 2024 01:36
@ebyhr ebyhr force-pushed the ebi/add-column-after branch 4 times, most recently from 2114dec to 8b60661 Compare June 1, 2024 00:58
@ebyhr ebyhr force-pushed the ebi/add-column-after branch 2 times, most recently from 6e509f1 to 37aa4dd Compare July 5, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector docs hive Hive connector iceberg Iceberg connector mongodb MongoDB connector stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. syntax-needs-review
Development

Successfully merging this pull request may close these issues.

[Iceberg] Support ADD Column at a particular index
3 participants