Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iceberg: Add support for creating and dropping tables using Iceberg object store #20555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakelong95
Copy link

Description

Currently, Trino is only able to write to and read from tables that use Iceberg's ObjectStorageLocationProvider, but is unable to create or drop tables using the location provider. This PR adds in session and table properties to use during table creation and removes an old check blocking Trino from dropping tables that use the object storage.

Additional context and related issues

This PR maintains compatibility with Spark by using the table properties write.object-storage.enabled and write.data.path, which had previously been set up to allow Trino to write to Iceberg tables using the ObjectStorageLocationProvider in #8573

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Iceberg
* Add support for creating and dropping tables using Iceberg object store  ({https://github.com/trinodb/trino/issues/8861}`8861`)

Copy link

cla-bot bot commented Feb 2, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@jakelong95
Copy link
Author

Re-created from #20516

@github-actions github-actions bot added tests:hive iceberg Iceberg connector labels Feb 2, 2024
@cla-bot cla-bot bot added the cla-signed label Apr 17, 2024
@jakelong95 jakelong95 marked this pull request as ready for review April 17, 2024 20:38
@mosabua mosabua requested a review from electrum April 17, 2024 20:55
@findinpath findinpath requested a review from homar April 26, 2024 10:07
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label May 17, 2024
@mosabua
Copy link
Member

mosabua commented May 29, 2024

Any thoughts @amogh-jahagirdar

@github-actions github-actions bot removed the stale label May 30, 2024
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants