-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion for property names #1
Comments
Fixed at v0.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
preferPlace
listed in the docs is verb + noun, for a better naming convention, noun or adjective + noun is a recommended practice for defining a property in any types (i.e. boolean, number, string, etc.), while verb or verb + noun is usually to define a property in boolean or function type. See following examples:Noun (or Adjective + Noun)
Verb (or Verb + Noun)
For this case, I suggest you replace
preferPlace
withplacement
, which will look much better.You can also refer to https://react-bootstrap.github.io/components.html#popover-props for details.
The text was updated successfully, but these errors were encountered: