Fix: Delta export path unescape #7473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E2E Test Results - DynamoDB Local - Local Block Adapter |
arielshaqed
approved these changes
Feb 19, 2024
Comment on lines
+536
to
+537
| accessKeyID := viper.GetString("access_key_id") | ||
| secretAccessKey := viper.GetString("secret_access_key") |
There was a problem hiding this comment.
Can we use testutil.SetupTestingEnv here?
There was a problem hiding this comment.
In what sense?
testutil.SetupTestingEnv configures the values (it is used in the TestMain and is run on every test)
Here we are just retrieving the values after running testutil.SetupTestingEnv
| @@ -111,7 +111,8 @@ local function export_delta_log(action, table_def_names, write_object, delta_cli | |||
| local code, obj = lakefs.stat_object(repo, commit_id, unescaped_path) | |||
| if code == 200 then | |||
| local obj_stat = json.unmarshal(obj) | |||
| local physical_path = obj_stat["physical_address"] | |||
| local u = url.parse(obj_stat["physical_address"]) | |||
| local physical_path = url.build_url(u["scheme"], u["host"], u["path"]) | |||
There was a problem hiding this comment.
Not sure why we parse and then build what looks like the exact same URL. Is this somehow the way to unescape? If so, please add a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7460
Change Description
Background
Fix issue where physical address is not escaped before writing it as path in the delta log file
Bug Fix
Issue root cause:
When importing data, physical address is saved unescaped. When exporting a delta table the log file is rewritten in the export location and the path is modified accordingly using the object physical address. For unescaped address which contain special characters in the path we are writing an invalid path.
Testing Details
Add + modify esti tests
Breaking Change?
No