Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CreateBranch permission check from Import #7362

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Remove CreateBranch permission check from Import #7362

merged 2 commits into from
Feb 4, 2024

Conversation

itaiad200
Copy link
Contributor

closes #7361

@itaiad200 itaiad200 added the exclude-changelog PR description should not be included in next release changelog label Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

🎊 PR Preview 16d4b7d has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-7362.surge.sh

🕐 Build time: 0.011s

🤖 By surge-preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

10 passed

@itaiad200
Copy link
Contributor Author

@N-o-Z why is fs:CreateBranch even needed for Import? I don't see a branch is being created at all. Even if it's needed, why should it be so permissive? Currently it's the ability to create any branch in the repo, shouldn't it be the specific branch the Import is trying to create?

@N-o-Z
Copy link
Member

N-o-Z commented Feb 4, 2024

@N-o-Z why is fs:CreateBranch even needed for Import? I don't see a branch is being created at all. Even if it's needed, why should it be so permissive? Currently it's the ability to create any branch in the repo, shouldn't it be the specific branch the Import is trying to create?

I honestly don't think it's needed anymore. In the past we created an intermediate import branch, today we just use a metarange for the merge.
I think this issue should remove the permission requirement instead of updating the documentation

N-o-Z
N-o-Z requested changes Feb 4, 2024
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove the permission

@itaiad200 itaiad200 changed the title Update import.md Remove CreateBranch permission check from Import Feb 4, 2024
@itaiad200 itaiad200 requested a review from N-o-Z February 4, 2024 09:14
@itaiad200 itaiad200 added include-changelog PR description should be included in next release changelog and removed exclude-changelog PR description should not be included in next release changelog labels Feb 4, 2024
N-o-Z
N-o-Z approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itaiad200 itaiad200 enabled auto-merge (squash) February 4, 2024 09:26
@itaiad200 itaiad200 merged commit c4be2a0 into master Feb 4, 2024
39 checks passed
@itaiad200 itaiad200 deleted the itaiad200-patch-2 branch February 4, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

@talSofer talSofer Awaiting requested review from talSofer

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary CreateBranch permission check in Import
2 participants
@itaiad200 @N-o-Z