lakectl presign large presigned download using multipart #7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E2E Test Results - DynamoDB Local - Local Block Adapter |
682c23d
to
1fd645e
Compare
|
♻️ PR Preview 0974161 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
idanovo
reviewed
Jan 17, 2024
| ) | ||
|
|
||
| const ( | ||
| DefaultDownloadPartSize int64 = 1024 * 1024 * 8 // 8MB |
There was a problem hiding this comment.
@nopcoder Don't you think we should add some way for the user to control it?
We can add another task for it if you don't think we should do it here
idanovo
approved these changes
Jan 17, 2024
Comment on lines
+82
to
+91
| // fallback to download if missing size | ||
| if statResp.JSON200 == nil || statResp.JSON200.SizeBytes == nil { | ||
| return d.downloadObject(ctx, src, dst) | ||
| } | ||
|
|
||
| // check if the object is small enough to download in one request | ||
| sizeBytes := *statResp.JSON200.SizeBytes | ||
| if sizeBytes < d.PartSize { | ||
| return d.downloadObject(ctx, src, dst) | ||
| } |
There was a problem hiding this comment.
Suggested change
| // fallback to download if missing size | |
| if statResp.JSON200 == nil || statResp.JSON200.SizeBytes == nil { | |
| return d.downloadObject(ctx, src, dst) | |
| } | |
| // check if the object is small enough to download in one request | |
| sizeBytes := *statResp.JSON200.SizeBytes | |
| if sizeBytes < d.PartSize { | |
| return d.downloadObject(ctx, src, dst) | |
| } | |
| // fallback to download if missing size | |
| if statResp.JSON200 == nil || statResp.JSON200.SizeBytes == nil || *statResp.JSON200.SizeBytes < d.PartSize { | |
| return d.downloadObject(ctx, src, dst) | |
| } |
And maybe add a log to indicate why we fallback to download
There was a problem hiding this comment.
- Don't think I need to log this decision
- Kept the two
ifto make the code clear
| const ( | ||
| MinDownloadPartSize int64 = 1024 * 64 // 64KB | ||
| DefaultDownloadPartSize int64 = 1024 * 1024 * 8 // 8MB | ||
| DefaultDownloadConcurrency = 10 |
There was a problem hiding this comment.
I think that one can be controlled by the user as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently supports only single large file download using presign.
Close #7283