Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gateway delete with branch protection should return 200 with error #7211

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Fix gateway delete with branch protection should return 200 with error #7211

merged 2 commits into from
Jan 1, 2024

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Dec 25, 2023 •
edited
Loading

Fix #7228

@nopcoder nopcoder added bug Something isn't working area/gateway Changes to the gateway include-changelog PR description should be included in next release changelog labels Dec 25, 2023
@nopcoder nopcoder self-assigned this Dec 25, 2023
@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

7 passed

@nopcoder
Fix gateway delete with branch protection should return 200 with error
e2bc8ba 
Current implementation return no content status code after we render an
error.
@nopcoder
fix return after encode error
8c3b169
@nopcoder nopcoder force-pushed the fix/gtw-delete-branch-protection branch from 36a7099 to 8c3b169 Compare January 1, 2024 09:08
@nopcoder nopcoder requested a review from idanovo January 1, 2024 09:08
idanovo
idanovo approved these changes Jan 1, 2024
View reviewed changes
Copy link
Contributor

@idanovo idanovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nopcoder nopcoder enabled auto-merge (squash) January 1, 2024 09:18
@nopcoder nopcoder disabled auto-merge January 1, 2024 09:18
@nopcoder nopcoder merged commit b53e7a7 into master Jan 1, 2024
35 checks passed
@nopcoder nopcoder deleted the fix/gtw-delete-branch-protection branch January 1, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idanovo idanovo idanovo approved these changes

Assignees

@nopcoder nopcoder

Labels
area/gateway Changes to the gateway bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 gateway delete api return no content status code on error
2 participants
@nopcoder @idanovo