Add ability to specify timeout and retries per relay #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this change backwards compatible in configuration? Will an old configuration still work (possibly with some defaults)? |
vkatsuba
reviewed
Feb 15, 2024
| _ -> {R, Relay, Pool} | ||
| case validate_route({Relay, RouteOptions}) of | ||
| false -> | ||
| false; |
There was a problem hiding this comment.
Here mixed tabs with spaces
Sorry for not reading the comments. Partially answered, but will the plain |
After the latest update it will. |
In this commit we add ability to specify 'timeout' and 'retries'
configuration options per proxy relay.
For example:
```
{default_route, {{127, 0, 0, 1}, 1813, <<"secret">>},
[{pool, pool_name}, {retries, 5}, {timeout, 5000}]
```
or
```
{routes, [{"^test-[0-9].", {{127, 0, 0, 1}, 1815, <<"secret1">>},
[{pool, pool_name}, {retries, 5}, {timeout, 5000}]}]}]
```
If 'retries' and 'timeout' are not specified default values from
`options` option will be used as before.
Backward compatibility is preserved. So, old configuration:
```
{default_route, {{127, 0, 0, 1}, 1813, <<"secret">>}, pool_name}
```
also will work
|
Thanks a lot :) |
| %% ''' | ||
| %% | ||
| %% Where the pool_name is optional field that contains list of | ||
| %% RADIUS servers pool name that will be used for fail-over. | ||
| %% Or for backward compatibility: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit we add ability to specify 'timeout' and 'retries' configuration options per proxy relay.
For example:
or
If 'retries' and 'timeout' are not specified default values from
optionsoption will be used as before.Backward compatibility is preserved. So, old configuration:
also will work.