Bugfix for Issue #12 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem was a deep list returned by format_unknown(). The deep list was no problem for the binaries which where used in the earlier logging. The currently used list_to_atom can't handle this, so instead the old structure is used and binary_to_atom is called. |
|
You should then use lists:flatten instead of going through the binary. Also, simply converting external data to atom's is not advisable and creates a memory leak!! |
|
Another discussed possibility was, to have: [{'$ejournald_meta', ExtraNonAtomKeys}] which can be in ejournald properly handled. |
sschindler89
force-pushed
the
ukid_bugfix
branch
from
f0542c7
to
272f3c5
Compare
sschindler89
pushed a commit
that referenced
this pull request
Apr 29, 2015
Bugfix for Issue #12 (unknown IDs leading to crashes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logging crashed for unknown attributes #12
this patch should fix this behaviour