Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate data structures in SDMX #62

Merged
merged 49 commits into from
Apr 12, 2021
Merged

Generate data structures in SDMX #62

merged 49 commits into from
Apr 12, 2021

Conversation

khaeru
Copy link
Contributor

@khaeru khaeru commented Feb 14, 2021

This code uses the sdmx1 package to give a complete and rigorous definition of the concepts, measures, codes, etc. used to structure the iTEM historical and model data.

Details

See the updated “Data structures” page in the documentation for more details, including motivation. This is a preview version built from the branch for this PR:

PR checklist

  • Complete code lists:
  • Add model and scenario concepts.
  • Make reference to the SDMX:CROSS_DOMAIN_CONCEPTS scheme where appropriate.
  • Add a distinct DSD for model data.
  • Improve existing code using the SDMX data structures:
    • Remove concepts.yaml and measures.yaml, now obsolete.
    • item.structure.make_template()
    • Use the DSD instead of the item.historical.scripts.util.managers.dataframe.ColumnName enum in data processing scripts.
  • Expand documentation with:
    • Code examples for retrieving code lists.

@khaeru khaeru added model Transport model projections historical Historical transport statistics labels Feb 14, 2021
@khaeru khaeru self-assigned this Feb 14, 2021
@khaeru khaeru added this to To do in iTEM Open Data via automation Feb 14, 2021
@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #62 (4c17224) into master (376def3) will increase coverage by 3.40%.
The diff coverage is 82.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   53.21%   56.61%   +3.40%     
==========================================
  Files          39       46       +7     
  Lines        1603     1851     +248     
==========================================
+ Hits          853     1048     +195     
- Misses        750      803      +53     
Impacted Files Coverage Δ
item/historical/scripts/T009.py 93.75% <ø> (ø)
item/tests/test_common.py 0.00% <0.00%> (ø)
item/tests/test_historical.py 0.00% <0.00%> (ø)
item/tests/test_structure.py 0.00% <0.00%> (ø)
item/cli.py 79.16% <37.50%> (ø)
item/structure/template.py 85.29% <85.29%> (ø)
item/structure/sdmx.py 92.64% <92.64%> (ø)
item/common.py 89.55% <100.00%> (ø)
item/historical/__init__.py 93.06% <100.00%> (+2.06%) ⬆️
item/historical/scripts/T000.py 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376def3...4c17224. Read the comment docs.

@khaeru khaeru force-pushed the feature/sdmx-dsd branch 4 times, most recently from f517c5d to 6405fe8 Compare February 19, 2021 09:48
khaeru added a commit to transportenergy/metadata that referenced this pull request Apr 12, 2021
@khaeru khaeru merged commit e6e3cfc into master Apr 12, 2021
iTEM Open Data automation moved this from In progress to Done Apr 12, 2021
@khaeru khaeru deleted the feature/sdmx-dsd branch April 12, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
historical Historical transport statistics model Transport model projections
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant