added some fonts #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkraetke
requested changes
Jan 10, 2019
There was a problem hiding this comment.
Hi @diakovidis, thanks for the PR. However, I would like to request some changes.
- There is no need to provide a font mapping for European Pi and Times New Roman as these fonts are compatible to Unicode. Would you please provide more background why you want to map these fonts?
- A mapping for the PostScript variant of Zapf Dingbats would be very useful. Since we are an OS project we would like to ask you, if you would like to contribute the complete mapping of Zapf Dingbats? I think this would be most helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added some extra characters