-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old demos, fix airbnb_reviews and add store demo #131
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
- Coverage 90.12% 89.92% -0.21%
==========================================
Files 24 24
Lines 901 883 -18
==========================================
- Hits 812 794 -18
Misses 89 89
☔ View full report in Codecov by Sentry. |
Had to remove bz2 dataset compression in the process since pip wasn't packaging it |
Also, there is only 1 integration test for airbnb reviews since the store integration test takes too long (3 hours, it's currently commented out for that reason) |
Co-authored-by: Gaurav Sheni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments. Overall, looks good.
This is because the file was not included here: |
Yep, this is fine. We should try to rely on unit tests as much as possible. |
No description provided.