Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old demos, fix airbnb_reviews and add store demo #131

Merged
merged 16 commits into from
Aug 10, 2023
Merged

Conversation

PatrikDurdevic
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.21% ⚠️

Comparison is base (093b1e4) 90.12% compared to head (6ae8521) 89.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   90.12%   89.92%   -0.21%     
==========================================
  Files          24       24              
  Lines         901      883      -18     
==========================================
- Hits          812      794      -18     
  Misses         89       89              
Files Changed Coverage Δ
trane/__init__.py 100.00% <100.00%> (ø)
trane/datasets/__init__.py 100.00% <100.00%> (ø)
trane/datasets/load_functions.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PatrikDurdevic PatrikDurdevic changed the title Remove covid19 and YouTube demos Remove old demos and add store demo Aug 6, 2023
@PatrikDurdevic PatrikDurdevic marked this pull request as ready for review August 7, 2023 02:45
@PatrikDurdevic
Copy link
Contributor Author

Had to remove bz2 dataset compression in the process since pip wasn't packaging it

@PatrikDurdevic PatrikDurdevic changed the title Remove old demos and add store demo Remove old demos, fix airbnb_reviews and add store demo Aug 7, 2023
@PatrikDurdevic
Copy link
Contributor Author

Also, there is only 1 integration test for airbnb reviews since the store integration test takes too long (3 hours, it's currently commented out for that reason)

Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments. Overall, looks good.

@gsheni
Copy link
Contributor

gsheni commented Aug 7, 2023

Had to remove bz2 dataset compression in the process since pip wasn't packaging it

This is because the file was not included here:
https://github.com/trane-dev/Trane/blob/main/pyproject.toml#L81

@gsheni
Copy link
Contributor

gsheni commented Aug 7, 2023

Also, there is only 1 integration test for airbnb reviews since the store integration test takes too long (3 hours, it's currently commented out for that reason)

Yep, this is fine. We should try to rely on unit tests as much as possible.

@gsheni gsheni merged commit 2cfe08b into main Aug 10, 2023
12 checks passed
@gsheni gsheni deleted the remove_old_demos branch August 10, 2023 18:24
@gsheni gsheni mentioned this pull request Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants