Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up operation description generation #118

Merged
merged 9 commits into from
Jul 28, 2023
Merged

Clean up operation description generation #118

merged 9 commits into from
Jul 28, 2023

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jul 28, 2023

@gsheni gsheni self-assigned this Jul 28, 2023
@gsheni gsheni marked this pull request as ready for review July 28, 2023 18:15
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: +0.76% 🎉

Comparison is base (dee4470) 89.47% compared to head (4c1ed3f) 90.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   89.47%   90.24%   +0.76%     
==========================================
  Files          26       25       -1     
  Lines         903      892      -11     
==========================================
- Hits          808      805       -3     
+ Misses         95       87       -8     
Files Changed Coverage Δ
trane/core/__init__.py 100.00% <ø> (ø)
trane/core/cutoff_strategy.py 100.00% <ø> (ø)
trane/ops/op_base.py 95.83% <ø> (-2.17%) ⬇️
trane/core/prediction_problem.py 83.33% <70.58%> (+3.92%) ⬆️
trane/ops/aggregation_ops.py 100.00% <100.00%> (ø)
trane/ops/filter_ops.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsheni gsheni merged commit 6f545cc into main Jul 28, 2023
10 of 11 checks passed
@gsheni gsheni deleted the better_desc branch July 28, 2023 18:31
@gsheni gsheni mentioned this pull request Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up PredictionProblemEvaluator
1 participant