Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude foreign keys from being used to generate prediction problems #108

Merged
merged 14 commits into from
Jul 27, 2023

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jul 26, 2023

  • Change "index" to "primary_key"
  • Fixes duplicate prediction problem generation by hashing all possible prediction problems
  • Allow Ops to restrict semantic tags

@gsheni gsheni self-assigned this Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 92.20% and project coverage change: +0.17% 🎉

Comparison is base (1a538c0) 89.30% compared to head (779fc7c) 89.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   89.30%   89.48%   +0.17%     
==========================================
  Files          26       26              
  Lines         851      894      +43     
==========================================
+ Hits          760      800      +40     
- Misses         91       94       +3     
Files Changed Coverage Δ
trane/datasets/load_functions.py 100.00% <ø> (ø)
trane/ops/filter_ops.py 100.00% <ø> (ø)
trane/parsing/denormalize.py 93.44% <ø> (ø)
trane/core/prediction_problem.py 79.16% <76.92%> (-0.36%) ⬇️
trane/core/prediction_problem_generator.py 92.13% <85.71%> (-1.27%) ⬇️
trane/core/utils.py 85.96% <95.45%> (+5.70%) ⬆️
trane/ops/aggregation_ops.py 100.00% <100.00%> (ø)
trane/ops/op_base.py 98.00% <100.00%> (+0.12%) ⬆️
trane/typing/inference.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsheni
Copy link
Contributor Author

gsheni commented Jul 27, 2023

Still need to add a few more unit tests and assertions

@gsheni gsheni marked this pull request as ready for review July 27, 2023 04:26
@gsheni gsheni merged commit d231910 into main Jul 27, 2023
11 checks passed
@gsheni gsheni deleted the exclude_foreign_keys branch July 27, 2023 13:56
@gsheni gsheni mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants