New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added set_cache_dir + refactoring to use pathlib.Path #71

Open

falcaopetri wants to merge 2 commits into trajminer:master from falcaopetri:data_download_refactoring

Contributor

falcaopetri commented Jul 31, 2020

We can now call trajminer.datasets.set_cache_dir to use a persistent cache directory (or still fall back to using a temporary folder).
trajminer.datasets.tools.py was refactored to use pathlib.Path.
Setting trajminer.load_*'s cache=True also caches the unzipped file¹.

¹ If desired, we can implement cache such that:

cache=False: no cache,
cache='compressed_only': cache download_file,
cache=True: cache download_file and extract_tar

(or something similar, depending on the expected defaults)

falcaopetri added 2 commits

July 31, 2020 15:41


Fixed wrong Brightkite dataset url

4d15cb8


Added set_cache_dir + refactoring to use pathlib.Path

68ba83b

lucaspetry added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment