Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interp: Add wasip1 to known OS list #1587

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Sep 2, 2023

Adds wasip1 to known OS list, introduced in golang/go#58141.

Without this change, yaegi extract may fail on Go 1.21 with the following message:

type-checking package "time" failed (<GOROOT>/src/time/zoneinfo_wasip1.go:8:5: platformZoneSources redeclared in this block)

@dennwc
Copy link
Contributor Author

dennwc commented Sep 21, 2023

@mvertes this one is small enough, should be fast to review.

@mvertes
Copy link
Member

mvertes commented Sep 23, 2023

This will be addressed through bringing the full support of Go1.21 which is in preparation, thanks.

Adds wasip1 to known OS list, introduced in golang/go#58141. Without this change, yaegi extract may fail.

(cherry picked from commit c7dbccf)
@dennwc
Copy link
Contributor Author

dennwc commented Sep 26, 2023

@mvertes I would advocate for merging it earlier, since it prevents yaegi extract from working with Go 1.21 installation at all, even if the project is configured for Go 1.20.

Copy link
Member

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvertes mvertes added this to the v0.15.x milestone Sep 26, 2023
@traefiker traefiker merged commit da27c4f into traefik:master Sep 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants