Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cube: Matmul tiling #1994

Merged
merged 85 commits into from
Jul 9, 2024
Merged

Cube: Matmul tiling #1994

merged 85 commits into from
Jul 9, 2024

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Jul 8, 2024

Matmul tiling again. Has undergone major refactoring and performance enhancing since my last draft.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 52.40729% with 1463 lines in your changes missing coverage. Please review.

Project coverage is 84.49%. Comparing base (c2b6318) to head (74b5d5b).

Files Patch % Lines
.../kernel/matmul/tiling2d_cube/load_shared_memory.rs 54.67% 291 Missing ⚠️
.../kernel/matmul/tiling2d_cube/tile/memory_access.rs 10.19% 185 Missing ⚠️
...jit/src/kernel/matmul/tiling2d_cube/tile/loader.rs 7.64% 157 Missing ⚠️
...l/tiling2d_cube/tile/block_io/whole_block_check.rs 4.46% 107 Missing ⚠️
...s/burn-jit/src/kernel/matmul/tiling2d_cube/base.rs 14.15% 97 Missing ⚠️
...iling2d_cube/tile/block_io/vertical_block_check.rs 6.66% 84 Missing ⚠️
...ing2d_cube/tile/block_io/horizontal_block_check.rs 7.86% 82 Missing ⚠️
...it/src/kernel/matmul/tiling2d_cube/write_output.rs 67.66% 65 Missing ⚠️
...mul/tiling2d_cube/tile/block_io/unchecked_block.rs 12.12% 58 Missing ⚠️
...-jit/src/kernel/matmul/tiling2d_cube/block_loop.rs 12.69% 55 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1994      +/-   ##
==========================================
- Coverage   85.38%   84.49%   -0.90%     
==========================================
  Files         821      840      +19     
  Lines      101427   104339    +2912     
==========================================
+ Hits        86603    88157    +1554     
- Misses      14824    16182    +1358     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louisfd louisfd mentioned this pull request Jul 9, 2024
@louisfd louisfd merged commit 69be99b into main Jul 9, 2024
15 checks passed
@louisfd louisfd deleted the refactor/cube/matmul_tiling_traits branch July 9, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants