Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/cube/mutability #1934

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Refactor/cube/mutability #1934

merged 7 commits into from
Jun 27, 2024

Conversation

nathanielsimard
Copy link
Member

@nathanielsimard nathanielsimard commented Jun 26, 2024

Now arrays and tensors are passed by reference to functions, since they don't implement copy anymore.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 47.15026% with 102 lines in your changes missing coverage. Please review.

Project coverage is 84.56%. Comparing base (f9ec2e1) to head (f13d063).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/burn-jit/src/kernel/contiguous.rs 41.26% 37 Missing ⚠️
...rates/burn-cube/src/frontend/element/vectorized.rs 0.00% 8 Missing ⚠️
crates/burn-cube/src/frontend/subcube.rs 27.27% 8 Missing ⚠️
crates/burn-jit/src/kernel/conv/conv2d.rs 16.66% 5 Missing ⚠️
crates/burn-cube/src/frontend/element/bool.rs 0.00% 4 Missing ⚠️
crates/burn-cube/src/frontend/element/float.rs 0.00% 4 Missing ⚠️
crates/burn-cube/src/frontend/element/int.rs 0.00% 4 Missing ⚠️
crates/burn-cube/src/frontend/element/tensor.rs 33.33% 4 Missing ⚠️
crates/burn-cube/src/runtime_tests/subcube.rs 0.00% 4 Missing ⚠️
crates/burn-cube/src/frontend/element/array.rs 25.00% 3 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1934      +/-   ##
==========================================
- Coverage   85.09%   84.56%   -0.54%     
==========================================
  Files         791      793       +2     
  Lines       93319    93859     +540     
==========================================
- Hits        79412    79370      -42     
- Misses      13907    14489     +582     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (shallow review, but i'll merge it in my stuff to see if it works well)

@louisfd louisfd merged commit 1ae1c03 into main Jun 27, 2024
15 checks passed
@louisfd louisfd deleted the refactor/cube/mutability branch June 27, 2024 20:03
@louisfd louisfd mentioned this pull request Jul 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants