Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle visibility in cube #1929

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Handle visibility in cube #1929

merged 1 commit into from
Jun 26, 2024

Conversation

nathanielsimard
Copy link
Member

Simply keep the same visibility as provided.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (4c90970) to head (a426f3e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1929   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files         790      790           
  Lines       93256    93267   +11     
=======================================
+ Hits        79335    79346   +11     
  Misses      13921    13921           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit f9ec2e1 into main Jun 26, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the fix/cube/visibility branch June 26, 2024 16:57
@louisfd louisfd mentioned this pull request Jul 2, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant