Perf/dynamic mm slice adressing #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rging (there is a bug with slice padding)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1917 +/- ##
==========================================
+ Coverage 85.02% 85.07% +0.04%
==========================================
Files 790 790
Lines 93275 93256 -19
==========================================
+ Hits 79310 79335 +25
+ Misses 13965 13921 -44 ☔ View full report in Codecov by Sentry. |
nathanielsimard
requested changes
Jun 25, 2024
| const MB: usize = 1024 * 1024; | ||
| fn main() { | ||
| let start = std::time::Instant::now(); | ||
| println!("Hello world!"); |
Comment on lines
70
to
72
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This else is not really useful
| slice_id.copied() | ||
| } | ||
|
|
||
| fn insert_slice(&mut self, position: usize, slice: &Slice) { |
nathanielsimard
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
#1752
Changes
Merging of slices was slow (removing from a vector O(n)). Switching to a memory page type of strategy where we index based on the offset of the memory slice. The offset is used to index into the memory page table. Since it's a HashMap removing a slice is done in O(1) time.
Testing
Ran Mnist workload and it improved speed quite a lot.