Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tanh nn wrapper #1903

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Tanh nn wrapper #1903

merged 2 commits into from
Jun 18, 2024

Conversation

DieracDelta
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Provide links to relevant issues and dependent PRs.

Changes

Add a wrapper (basically copy-pasta of relu) for the tanh activation function

Testing

Haven't included any tests.

@DieracDelta DieracDelta changed the title feat: tanh nn wrapper Tanh nn wrapper Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.59%. Comparing base (8071b63) to head (9748281).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/burn-core/src/nn/tanh.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1903      +/-   ##
==========================================
- Coverage   86.09%   85.59%   -0.50%     
==========================================
  Files         781      786       +5     
  Lines       91688    92127     +439     
==========================================
- Hits        78935    78857      -78     
- Misses      12753    13270     +517     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple mistake to be corrected before merging, thanks

crates/burn-core/src/nn/tanh.rs Outdated Show resolved Hide resolved
@nathanielsimard nathanielsimard merged commit 263add2 into tracel-ai:main Jun 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants