Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cube: Vectorization + simple matmul implementation #1866

Merged
merged 13 commits into from
Jun 7, 2024

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Jun 7, 2024

In this PR:

  • Adequate vectorization support
  • New simple matmul written with Cube. Vectorized on inputs in the dimension K
  • Mutability info in Variable analysis
  • Fix assignation:
    • For expand element, a new variable is always used if inplace is not available and it does not come from a Comptime function. This removes potential bugs with mutability
    • Other structs can define their own init behaviour, most of them being do nothing

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 69.62233% with 185 lines in your changes missing coverage. Please review.

Project coverage is 86.10%. Comparing base (4b174a8) to head (fb3c519).

Files Patch % Lines
crates/burn-jit/src/kernel/matmul/simple.rs 32.89% 51 Missing ⚠️
crates/burn-cube/src/frontend/element/int.rs 0.00% 32 Missing ⚠️
crates/burn-cube/src/frontend/element/float.rs 41.17% 20 Missing ⚠️
crates/burn-cube/src/frontend/element/uint.rs 40.62% 19 Missing ⚠️
crates/burn-cube/tests/language/assign.rs 86.52% 19 Missing ⚠️
...rates/burn-cube/src/frontend/element/vectorized.rs 40.00% 9 Missing ⚠️
.../burn-cube-macros/src/codegen_function/function.rs 86.44% 8 Missing ⚠️
crates/burn-cube/src/frontend/comptime.rs 58.82% 7 Missing ⚠️
crates/burn-cube/src/frontend/element/base.rs 33.33% 6 Missing ⚠️
crates/burn-cube-macros/src/analysis.rs 75.00% 5 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
- Coverage   86.24%   86.10%   -0.14%     
==========================================
  Files         774      776       +2     
  Lines       90159    90496     +337     
==========================================
+ Hits        77759    77924     +165     
- Misses      12400    12572     +172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louisfd louisfd merged commit de5b681 into main Jun 7, 2024
15 checks passed
@louisfd louisfd deleted the refactor/cube/mem_coalescing branch June 7, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant