Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeat for dims > 1 #1713

Merged
merged 3 commits into from
May 1, 2024
Merged

Fix repeat for dims > 1 #1713

merged 3 commits into from
May 1, 2024

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Apr 30, 2024

Allow repeat operation to repeat a dimension that is larger than one, instead of panicking.

  • Changed and refactored default implementation based on slice_assign which is used by ndarray and candle
  • Changed jit kernel
  • Added tests

Fix #1670

@louisfd louisfd changed the title Fix/repeat/larger dim Fix repeat for dims > 1 Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.42%. Comparing base (587b8f8) to head (ec98ac3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
+ Coverage   86.41%   86.42%   +0.01%     
==========================================
  Files         698      699       +1     
  Lines       81787    81829      +42     
==========================================
+ Hits        70674    70720      +46     
+ Misses      11113    11109       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antimora
Copy link
Collaborator

Linking a related task: #1715

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit 2e4c82f into main May 1, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the fix/repeat/larger_dim branch May 1, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run llama2-burn on webgpu
3 participants