Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lstm batch size bug #1695

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Fix lstm batch size bug #1695

merged 2 commits into from
Apr 26, 2024

Conversation

nathanielsimard
Copy link
Member

Fix #1656

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.42%. Comparing base (67ec06d) to head (f81a172).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1695   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files         696      696           
  Lines       81076    81085    +9     
=======================================
+ Hits        70071    70080    +9     
  Misses      11005    11005           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit 2f294c5 into main Apr 26, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the fix/lstm-bug branch April 26, 2024 12:54
syl20bnr pushed a commit that referenced this pull request Apr 26, 2024
syl20bnr pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the batch size is 1, testing LSTM on the Wgpu backend will fail
2 participants