Tweak/add kind to gelu benchmark name #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1533 +/- ##
==========================================
- Coverage 86.36% 86.34% -0.02%
==========================================
Files 682 682
Lines 77849 77861 +12
==========================================
- Hits 67231 67230 -1
- Misses 10618 10631 +13 ☔ View full report in Codecov by Sentry. |
nathanielsimard
requested changes
Mar 26, 2024
| true => "gelu_autodiff", | ||
| false => "gelu", | ||
| true => format!("gelu_autodiff_{:?}", self.kind), | ||
| false => format!("gelu_{:?}", self.kind), | ||
| } | ||
| .into() |
There was a problem hiding this comment.
Don't need the into with the format now.
4d588fc
to
b68a6c3
Compare
b68a6c3
to
2a9b849
Compare
nathanielsimard
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
Provide links to relevant issues and dependent PRs.
Changes
Add the kind to gelu benchmark name. Also compute the space required in each column of the report table.
This gives the following names: