Skip to content

Commit

Permalink
Fix Windows Git path issues
Browse files Browse the repository at this point in the history
from upgrade to Git 2.x, causing failure of spawn test on appveyor

also remove busybox since Git 2.x makes it unnecessary
  • Loading branch information
tkelman committed Oct 9, 2015
1 parent de30806 commit c18d271
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 16 deletions.
3 changes: 1 addition & 2 deletions LICENSE.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,9 @@ Julia's build process uses the following external tools:
Julia bundles the following external programs and libraries on some platforms:

- [7-Zip](http:https://www.7-zip.org/license.txt)
- [BUSYBOX](https://github.com/rmyorston/busybox-w32/blob/master/LICENSE)
- [GIT](http:https://git-scm.com/about/free-and-open-source)
- [ZLIB](http:https://zlib.net/zlib_license.html)
- [LIBEXPAT](http:https://expat.cvs.sourceforge.net/viewvc/expat/expat/README)
- [OPENSSL](https://github.com/openssl/openssl/blob/master/LICENSE)

On some platforms, distributions of Julia contain SSL certificate authority certificates, released under the [Mozilla Public License](https://en.wikipedia.org/wiki/Mozilla_Public_License).
On some platforms, distributions of Julia contain SSL certificate authority certificates, released under the [Mozilla Public License](https://en.wikipedia.org/wiki/Mozilla_Public_License).
10 changes: 3 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -465,10 +465,8 @@ ifeq ($(OS), WINNT)
cp 7z.exe 7z.dll libexpat-1.dll zlib1.dll libgfortran-3.dll libquadmath-0.dll libstdc++-6.dll libgcc_s_s*-1.dll libssp-0.dll $(bindir) && \
mkdir $(DESTDIR)$(prefix)/Git && \
7z x PortableGit.7z -o"$(DESTDIR)$(prefix)/Git" && \
echo "[core] eol = lf" >> "$(DESTDIR)$(prefix)/Git/etc/gitconfig" && \
sed -i "s/\bautocrlf = true$$/autocrlf = input/" "$(DESTDIR)$(prefix)/Git/etc/gitconfig" && \
cp busybox.exe $(DESTDIR)$(prefix)/Git/bin/echo.exe && \
cp busybox.exe $(DESTDIR)$(prefix)/Git/bin/printf.exe )
echo "[core] eol = lf" >> "$(DESTDIR)$(prefix)"/Git/mingw*/etc/gitconfig && \
sed -i "s/\bautocrlf = true$$/autocrlf = input/" "$(DESTDIR)$(prefix)"/Git/mingw*/etc/gitconfig )
cd $(DESTDIR)$(bindir) && rm -f llvm* llc.exe lli.exe opt.exe LTO.dll bugpoint.exe macho-dump.exe

# create file listing for uninstall. note: must have Windows path separators and line endings.
Expand Down Expand Up @@ -612,9 +610,7 @@ endif
cd $(JULIAHOME)/dist-extras && \
$(JLDOWNLOAD) http:https://downloads.sourceforge.net/sevenzip/7z920_extra.7z && \
$(JLDOWNLOAD) https://unsis.googlecode.com/files/nsis-2.46.5-Unicode-setup.exe && \
$(JLDOWNLOAD) busybox.exe http:https://frippery.org/files/busybox/busybox-w32-FRP-1-g9eb16cb.exe && \
chmod a+x 7z.exe && \
chmod a+x 7z.dll && \
$(call spawn,./7z.exe) x -y -onsis nsis-2.46.5-Unicode-setup.exe && \
chmod a+x ./nsis/makensis.exe && \
chmod a+x busybox.exe
chmod a+x ./nsis/makensis.exe
6 changes: 2 additions & 4 deletions contrib/windows/juliarc.jl
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# This file is a part of Julia. License is MIT: http:https://julialang.org/license

let user_data_dir
ENV["PATH"] = JULIA_HOME*";"*joinpath(JULIA_HOME,"..","Git","bin")*";"*ENV["PATH"]
#haskey(ENV,"JULIA_EDITOR") || (ENV["JULIA_EDITOR"] = "start") #start is not a program, so this doesn't work
end
ENV["PATH"] = JULIA_HOME*";"*joinpath(JULIA_HOME,"..","Git","bin")*";"*
joinpath(JULIA_HOME,"..","Git","usr","bin")*";"*ENV["PATH"]
4 changes: 1 addition & 3 deletions contrib/windows/msys_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ if ! [ -e julia-installer.exe ]; then
echo "Extracting $f"
$SEVENZIP x -y $f >> get-deps.log
fi
for i in bin/*.dll Git/bin/msys-1.0.dll Git/bin/msys-perl5_8.dll Git/bin/*.exe; do
for i in bin/*.dll Git/usr/bin/*.dll Git/usr/bin/*.exe; do
$SEVENZIP e -y julia-installer.exe "\$_OUTDIR/$i" \
-ousr\\`dirname $i | sed -e 's|/julia||' -e 's|/|\\\\|g'` >> get-deps.log
done
Expand Down Expand Up @@ -179,8 +179,6 @@ if [ -z "`which make 2>/dev/null`" ]; then
fi
$SEVENZIP x -y `basename $f.lzma` >> get-deps.log
tar -xf `basename $f`
# msysgit has an ancient version of touch that fails with `touch -c nonexistent`
cp usr/Git/bin/echo.exe bin/touch.exe
export PATH=$PWD/bin:$PATH
fi

Expand Down

0 comments on commit c18d271

Please sign in to comment.