REPL completion: indentifers after using must be comma separated

tpapp · Aug 12, 2017 · 1343e23 · 1343e23
1 parent 143c9e2
commit 1343e23
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/base/repl/REPLCompletions.jl b/base/repl/REPLCompletions.jl
@@ -368,7 +368,7 @@ function afterusing(string::String, startpos::Int)
  r = search(rstr, r"\s(gnisu|tropmi)\b")
  isempty(r) && return false
  fr = reverseind(str, last(r))
- return ismatch(r"^\b(using|import)\s*((\w+[.])*\w+\s*,\s*)*\w*$", str[fr:end])
+ return ismatch(r"^\b(using|import)\s*((\w+[.])*\w+\s*,\s*)*$", str[fr:end])
 end
 
 function bslash_completions(string, pos)

diff --git a/test/replcompletions.jl b/test/replcompletions.jl
@@ -167,6 +167,11 @@ s = "using Base.Test, Base.Random"
 c,r = test_complete(s)
 @test !("RandomDevice" in c)
 
+# issue #23226: identifiers must be separated by a comma (not a newline)
+s = "using Base\nusi"
+c,r = test_complete(s)
+@test "using" in c
+
 # inexistent completion inside a string
 s = "Pkg.add(\"lol"
 c,r,res = test_complete(s)