-
-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP-518 wheel support #850
Comments
This may require changing some CLI and ini options. |
@rpkilby yeah I know, we'll need to shim them around. I would propose the word |
…led commands (#852) #850 PEP-518 support: provide a tox configuration flag ``build`` which can be either ``sdist`` or ``wheel``. For ``sdist`` (default) we build the package as before by using ``python setup.py sdist``. However, when ``wheel`` is enabled now we'll use ``pip wheel`` to build it, and we'll also install wheels in these case into the environments. Note: ``pip`` 10 supports specifying project dependencies (such as ``setuptools-scm``, or a given ``setuptools`` version) via ``pyproject.toml``. Once ``pip`` supports building ``sdist`` to we'll migrate over the ``sdist`` build too. #851 While running tox invokes various commands (such as building the package, pip installing dependencies and so on), these were printed in case they failed as Python arrays. Changed the representation to a shell command, allowing the users to quickly replicate/debug the failure on their own.
This has now been retired. The plan is to first trial wheel support via a plugin outside of the core. |
@gaborbernat - are you planning on creating this plugin, or is this something someone else should pick up? Edit: I'm happy to look into it, but don't want to duplicate your efforts if you're already half way through creating your own plugin. |
No immediate plans as they are other pressing core issues. I'll happily review it though and we'll host it under our organisation if you go ahead with it. |
btw - I haven't pursued this any further yet. It's on my eventual todo list, but there are a lot of other things on my plate that have higher priority. For now, building the wheel outside of tox and using the Note to self: complications mentioned in #232 (comment). |
Done under https://github.com/ionelmc/tox-wheel
|
nice 👍 |
We'll add PEP-518 support by exposing the following:
python setup.py sdist
withpip wheel
to build packages,sdist
,sdist
s.The benefit of doing this is that now users can specify their project dependencies for
setuptools
projects by usingpyproject.toml
.Because sometimes
sdist
may be prefered and pip does not support building those yet; for now we'll expose it with an on-demandbuild = wheel
tox config. By defaultbuild = sdist
and this will keep doingpython setup.py sdist
. Once pip supports buildingsdist
we'll replacepython setup.py sdist
with that command.Will create the PR for this in the following days.
Full PEP-517 support (e.g. flint, etc is tracked by #573).
The text was updated successfully, but these errors were encountered: