Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic .gitignore #2530

Open
adamchainz opened this issue Nov 6, 2022 · 4 comments
Open

Automatic .gitignore #2530

adamchainz opened this issue Nov 6, 2022 · 4 comments
Labels
feature:new something does not exist yet, but should help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.

Comments

@adamchainz
Copy link
Contributor

Some testing tools add a .gitignore with a * rule into the temporary directories they create. This saves projects needing to add a pattern to their Git ignore file, and prevents accidents where such a pattern is missing. For example, Coverage.py does so, since version 6.1.

Perhaps tox could do the same when creating a .tox directory?
@adamchainz adamchainz added the feature:new something does not exist yet, but should label Nov 6, 2022
@jugmac00
Copy link
Member

jugmac00 commented Nov 6, 2022

Sounds good to me. Let's wait for feedback whether the other maintainers have any objections.

@gaborbernat
Copy link
Member

Go for it!

@gaborbernat gaborbernat added the help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. label Jun 16, 2023
@jugmac00
Copy link
Member

FWIW - the virtual environments below .tox already come with a .gitignore, automatically created by virtualenv.

@adamchainz adamchainz mentioned this issue Aug 10, 2023
Closed
@kurtmckee
Copy link
Contributor

However, if an interpreter is missing, a .tox-info.json file is still created, as I discovered when I ran a test suite but didn't have a few PyPy versions installed:

.tox/pypy38/.tox-info.json
.tox/pypy39/.tox-info.json

A top-level .gitignore in .tox/ is still desirable.

kurtmckee added a commit to kurtmckee/pr-tox that referenced this issue Oct 30, 2023
@kurtmckee
Create a .gitignore in work_dir and info file directories
cf8817b 
Closes tox-dev#2530
@kurtmckee kurtmckee mentioned this issue Oct 30, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature:new something does not exist yet, but should help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a .gitignore in work_dir and info file directories kurtmckee/pr-tox
4 participants
@kurtmckee @gaborbernat @adamchainz @jugmac00